This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(algebra/order/field): don't import finiteness hierarchy#17350
Closed
[Merged by Bors] - chore(algebra/order/field): don't import finiteness hierarchy#17350
Conversation
1 task
Collaborator
|
I didn't realize bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Vierkantor
reviewed
Nov 4, 2022
Member
|
Why |
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Collaborator
Author
|
bors merge |
Collaborator
Author
As I'm just moving things around in this PR, I'm not going to try to generalize here. |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
This problem was just introduced in #16971. Hopefully we can all be careful about not adding heavy imports to fundamental files. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
This problem was just introduced in #16971. Hopefully we can all be careful about not adding heavy imports to fundamental files. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Nov 5, 2022
This problem was just introduced in #16971. Hopefully we can all be careful about not adding heavy imports to fundamental files. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
This just pulls some material about powers of elements in linearly ordered fields into a separate file, as it isn't on the critical path to `linear_ordered_field ℚ`. This will break in CI a few times as I find the downstream imports that need it. - [x] depends on: #17350 [](https://gitpod.io/from-referrer/) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
This just pulls some material about powers of elements in linearly ordered fields into a separate file, as it isn't on the critical path to `linear_ordered_field ℚ`. This will break in CI a few times as I find the downstream imports that need it. - [x] depends on: #17350 [](https://gitpod.io/from-referrer/) Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem was just introduced in #16971. Hopefully we can all be careful about not adding heavy imports to fundamental files.