This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/option/n_ary): Binary map of options#16763
Closed
YaelDillies wants to merge 6 commits intomasterfrom
Closed
[Merged by Bors] - feat(data/option/n_ary): Binary map of options#16763YaelDillies wants to merge 6 commits intomasterfrom
YaelDillies wants to merge 6 commits intomasterfrom
Conversation
1 task
b-mehta
reviewed
Oct 2, 2022
src/data/option/n_ary.lean
Outdated
| (map₂ f a b).map g = map₂ f' (a.map g₁) (b.map g₂) := | ||
| by cases a; cases b; simp [h_distrib] | ||
|
|
||
| /-- Symmetric of `option.map₂_map_left_comm`. -/ |
Collaborator
There was a problem hiding this comment.
"Symmetric of" doesn't really make sense in English - I'm not sure what you mean here?
Collaborator
Author
There was a problem hiding this comment.
Same equality but written the other way around.
If you wonder why we need this, it's because unification has a hard time figuring all the functions if you symmetrize on the spot. This is also how the other n-ary APIs do it.
Collaborator
There was a problem hiding this comment.
In that case, how about:
Suggested change
| /-- Symmetric of `option.map₂_map_left_comm`. -/ | |
| /-- Symmetric form of `option.map₂_map_left_comm`. -/ |
or
Suggested change
| /-- Symmetric of `option.map₂_map_left_comm`. -/ | |
| /-- Symmetric restatement of `option.map₂_map_left_comm`. -/ |
(also below)
Vierkantor
approved these changes
Oct 24, 2022
src/data/option/n_ary.lean
Outdated
| (map₂ f a b).map g = map₂ f' (a.map g₁) (b.map g₂) := | ||
| by cases a; cases b; simp [h_distrib] | ||
|
|
||
| /-- Symmetric of `option.map₂_map_left_comm`. -/ |
Collaborator
There was a problem hiding this comment.
In that case, how about:
Suggested change
| /-- Symmetric of `option.map₂_map_left_comm`. -/ | |
| /-- Symmetric form of `option.map₂_map_left_comm`. -/ |
or
Suggested change
| /-- Symmetric of `option.map₂_map_left_comm`. -/ | |
| /-- Symmetric restatement of `option.map₂_map_left_comm`. -/ |
(also below)
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
Define `option.map₂`, the binary map of options.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
Define `option.map₂`, the binary map of options.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
option.map₂, the binary map of options.This will be used to turn arithmetic operations on
nonempty_interval αinto the ones oninterval α.