This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - test(instance_diamonds): verify that restrict_scalars produces no diamonds on the complex numbers#12273
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
Conversation
…monds on the complex numbers
17 tasks
Collaborator
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
…monds on the complex numbers (#12273) There is already a comment on `complex.module` that indicates an intentional solution to this diamond.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already a comment on
complex.modulethat indicates an intentional solution to this diamond.