This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(topology/metric_space): multiplicative opposites inherit the same (pseudo_?)(e?)metric and uniform_space#12120
Closed
eric-wieser wants to merge 9 commits intomasterfrom
Closed
Conversation
17205ad to
856369d
Compare
17 tasks
urkud
reviewed
Feb 22, 2022
urkud
reviewed
Feb 22, 2022
(pseudo_?)(e?)metric and uniform_space
urkud
reviewed
Feb 23, 2022
urkud
reviewed
Feb 23, 2022
Member
|
Otherwise LGTM. |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2022
…e `(pseudo_?)(e?)metric` and `uniform_space` (#12120) This puts the "obvious" metric on the opposite type such that `dist (op x) (op y) = dist x y`. This also merges `subtype.pseudo_dist_eq` and `subtype.dist_eq` as the latter was a special case of the former.
|
Pull request successfully merged into master. Build succeeded: |
(pseudo_?)(e?)metric and uniform_space(pseudo_?)(e?)metric and uniform_space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This puts the "obvious" metric on the opposite type such that
dist (op x) (op y) = dist x y.This also merges
subtype.pseudo_dist_eqandsubtype.dist_eqas the latter was a special case of the former.