This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(topology/algebra/module/basic): remove two duplicate lemmas#12072
Closed
eric-wieser wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore(topology/algebra/module/basic): remove two duplicate lemmas#12072eric-wieser wants to merge 1 commit intomasterfrom
eric-wieser wants to merge 1 commit intomasterfrom
Conversation
These are in the wrong namespace, and are identical to the lemmas in the right namespace but with unecessarily strong assumptions.
Member
|
Thanks! |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
…2072) `continuous_linear_map.continuous_nsmul` is nothing to do with `continuous_linear_map`s, and is the same as `continuous_nsmul`, but the latter doesn't require commutativity. There is no reason to keep the former. This lemma was added in #7084, but probably got missed due to how large that PR had to be. We can't remove `continuous_linear_map.continuous_zsmul` until #12055 is merged, as there is currently no `continuous_zsmul` in the root namespace.
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2022
This lemma duplicates the lemma of the same name in the root namespace, and should not be in this namespace in the first place. The other half of #12072, now that the dependent PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuous_linear_map.continuous_nsmulis nothing to do withcontinuous_linear_maps, and is the same ascontinuous_nsmul, but the latter doesn't require commutativity. There is no reason to keep the former.This lemma was added in #7084, but probably got missed due to how large that PR had to be.
We can't remove
continuous_linear_map.continuous_zsmuluntil #12055 is merged, as there is currently nocontinuous_zsmulin the root namespace.