This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(linear_algebra/affine_space/affine_map,topology/algebra/continuous_affine_map): generalized scalar instances#11978
Closed
eric-wieser wants to merge 6 commits intomasterfrom
Closed
Conversation
17 tasks
ocfnash
approved these changes
Feb 16, 2022
| section distrib_mul_action | ||
| variables [monoid R] [distrib_mul_action R V2] [smul_comm_class k R V2] | ||
|
|
||
| /-- Affine maps to a module inherit `R`-actions from that module. -/ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /-- Affine maps to a module inherit `R`-actions from that module. -/ | |
| /-- The space of affine maps to a module inherits an `R`-action from the action on its codomain. -/ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
…ous_affine_map): generalized scalar instances (#11978) The main result here is that `distrib_mul_action`s are available on affine maps to a module, inherited from their codomain. This fixes a diamond in the `int`-action that was already present for `int`-affine maps, and prevents the new `nat`-action introducing a diamond. This also removes the requirement for `R` to be a `topological_space` in the scalar action for `continuous_affine_map` by using `has_continuous_const_smul` instead of `has_continuous_smul`.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main result here is that
distrib_mul_actions are available on affine maps to a module, inherited from their codomain.This fixes a diamond in the
int-action that was already present forint-affine maps, and prevents the newnat-action introducing a diamond.This also removes the requirement for
Rto be atopological_spacein the scalar action forcontinuous_affine_mapby usinghas_continuous_const_smulinstead ofhas_continuous_smul.