This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(topology/algebra/module/multilinear): relax typeclass arguments#11972
Closed
eric-wieser wants to merge 3 commits intomasterfrom
Closed
[Merged by Bors] - chore(topology/algebra/module/multilinear): relax typeclass arguments#11972eric-wieser wants to merge 3 commits intomasterfrom
eric-wieser wants to merge 3 commits intomasterfrom
Conversation
17 tasks
bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2022
…#11972) Previously `module R' (continuous_multilinear_map A M₁ M₂)` required `algebra R' A`, but now it only requires `smul_comm_class A R' M₂`. The old instance required (modulo argument reordering): ```lean def continuous_multilinear_map.module {ι : Type v} {M₁ : ι → Type w₁} {M₂ : Type w₂} [decidable_eq ι] [Π i, add_comm_monoid (M₁ i)] [add_comm_monoid M₂] [Π i, topological_space (M₁ i)] [topological_space M₂] [has_continuous_add M₂] {R' : Type u_1} {A : Type u_2} [comm_semiring R'] [semiring A] [topological_space R'] [Π i, module A (M₁ i)] [module A M₂] [module R' M₂] [has_continuous_smul R' M₂] [algebra R' A] [is_scalar_tower R' A M₂] : module R' (continuous_multilinear_map A M₁ M₂) ``` while the new one requires ```lean def continuous_multilinear_map.module {ι : Type v} {M₁ : ι → Type w₁} {M₂ : Type w₂} [decidable_eq ι] [Π i, add_comm_monoid (M₁ i)] [add_comm_monoid M₂] [Π i, topological_space (M₁ i)] [topological_space M₂] [has_continuous_add M₂] {R' : Type u_1} {A : Type u_2} [semiring R'] [semiring A] [topological_space R'] -- note: `R'` not commutative any more [Π i, module A (M₁ i)] [module A M₂] [module R' M₂] [has_continuous_smul R' M₂] [smul_comm_class A R' M₂] : -- note: `R'` needs no action at all on `A` module R' (continuous_multilinear_map A M₁ M₂) ``` This change also adds intermediate `mul_action` and `distrib_mul_action` instances which apply in weaker situations. As a result of this weakening, the typeclass arguments to `continuous_multilinear_map.to_normed_space` can also be weakened, and a weird instance workaround can be removed.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
module R' (continuous_multilinear_map A M₁ M₂)requiredalgebra R' A, but now it only requiressmul_comm_class A R' M₂.The old instance required (modulo argument reordering):
while the new one requires
This change also adds intermediate
mul_actionanddistrib_mul_actioninstances which apply in weaker situations.As a result of this weakening, the typeclass arguments to
continuous_multilinear_map.to_normed_spacecan also be weakened, and a weird instance workaround can be removed.