This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/sum/interval): The disjoint sum of two locally finite orders is locally finite#11351
Closed
YaelDillies wants to merge 11 commits intomasterfrom
Closed
[Merged by Bors] - feat(data/sum/interval): The disjoint sum of two locally finite orders is locally finite#11351YaelDillies wants to merge 11 commits intomasterfrom
YaelDillies wants to merge 11 commits intomasterfrom
Conversation
1 task
eric-wieser
reviewed
Jan 10, 2022
eric-wieser
reviewed
Jan 10, 2022
eric-wieser
reviewed
Jan 10, 2022
eric-wieser
reviewed
Jan 10, 2022
b-mehta
reviewed
Jan 15, 2022
b-mehta
reviewed
Jan 15, 2022
Member
|
Can you elaborate on what the link to #11352 here is? Do you want that PR in before this one? |
eric-wieser
approved these changes
Jan 19, 2022
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d=b-mehta
Looks good to me, let's see if @b-mehta has anything left to add
|
✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with |
Collaborator
Author
|
If you look at #11352, you will see that def ultimate_sum_lift : Π (a : α₁ ⊕ α₂) (b : β₁ ⊕ β₂), finset (γ₁ ⊕ γ₂)
| (inl a) (inl b) := (f₁ a b).map ⟨_, inl_injective⟩
| (inl a) (inr b) := (g₁ a b).disj_sum (g₂ a b)
| (inr a) (inl b) := (h₁ a b).disj_sum (h₂ a b)
| (inr a) (inr b) := (f₂ a b).map ⟨_, inr_injective⟩and I was wondering
|
Collaborator
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2022
…s is locally finite (#11351) This proves `locally_finite_order (α ⊕ β)` where `α` and `β` are locally finite themselves.
|
Pull request successfully merged into master. Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proves
locally_finite_order (α ⊕ β)whereαandβare locally finite themselves.Please have a look at #11352 to see whether you think generalizing
sum_lift₂to four or even six functions is worth it.