Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/sum/interval): The disjoint sum of two locally finite orders is locally finite#11351

Closed
YaelDillies wants to merge 11 commits intomasterfrom
localfinorder_sum
Closed

[Merged by Bors] - feat(data/sum/interval): The disjoint sum of two locally finite orders is locally finite#11351
YaelDillies wants to merge 11 commits intomasterfrom
localfinorder_sum

Conversation

@YaelDillies
Copy link
Copy Markdown
Collaborator

This proves locally_finite_order (α ⊕ β) where α and β are locally finite themselves.


Please have a look at #11352 to see whether you think generalizing sum_lift₂ to four or even six functions is worth it.

Open in Gitpod

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 11, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 11, 2022
@b-mehta b-mehta added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 15, 2022
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 17, 2022
@eric-wieser
Copy link
Copy Markdown
Member

Can you elaborate on what the link to #11352 here is? Do you want that PR in before this one?

Copy link
Copy Markdown
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d=b-mehta

Looks good to me, let's see if @b-mehta has anything left to add

@bors
Copy link
Copy Markdown

bors bot commented Jan 19, 2022

✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the delegated The PR author may merge after reviewing final suggestions. label Jan 19, 2022
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the awaiting-review The author would like community review of the PR label Jan 19, 2022
@YaelDillies
Copy link
Copy Markdown
Collaborator Author

YaelDillies commented Jan 19, 2022

If you look at #11352, you will see that sum_lift₂ is a special case of sum_lex_lift, which is itself a special case of

def ultimate_sum_lift : Π (a : α₁ ⊕ α₂) (b : β₁ ⊕ β₂), finset (γ₁ ⊕ γ₂)
| (inl a) (inl b) := (f₁ a b).map ⟨_, inl_injective⟩
| (inl a) (inr b) := (g₁ a b).disj_sum (g₂ a b)
| (inr a) (inl b) := (h₁ a b).disj_sum (h₂ a b)
| (inr a) (inr b) := (f₂ a b).map ⟨_, inr_injective⟩

and I was wondering

  • whether sum_lift₂ should live
  • which generality you wanted me to use

@b-mehta
Copy link
Copy Markdown
Collaborator

b-mehta commented Jan 19, 2022

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 19, 2022
bors bot pushed a commit that referenced this pull request Jan 19, 2022
…s is locally finite (#11351)

This proves `locally_finite_order (α ⊕ β)` where `α` and `β` are locally finite themselves.
@bors
Copy link
Copy Markdown

bors bot commented Jan 19, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/sum/interval): The disjoint sum of two locally finite orders is locally finite [Merged by Bors] - feat(data/sum/interval): The disjoint sum of two locally finite orders is locally finite Jan 19, 2022
@bors bors bot closed this Jan 19, 2022
@bors bors bot deleted the localfinorder_sum branch January 19, 2022 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants