This repository was archived by the owner on Jul 24, 2024. It is now read-only.
refactor(group_theory/abelianization): simplify abelianization #1126
Merged
mergify[bot] merged 16 commits intoleanprover-community:masterfrom Jun 11, 2019
Michael-Howes:master
Merged
refactor(group_theory/abelianization): simplify abelianization #1126mergify[bot] merged 16 commits intoleanprover-community:masterfrom Michael-Howes:master
mergify[bot] merged 16 commits intoleanprover-community:masterfrom
Michael-Howes:master
Conversation
define group conjugates and normal closure
Presented groups are defined as a quotient of a free group by the normal subgroup the relations generate.
Presented groups are defined as a quotient of a free group by the normal subgroup the relations generate
Co-Authored-By: Keeley Hoek <keeley@hoek.io>
The commutator of a group was previously defined using lists. Now it is defined using `normal_closure`. This change simplifies some of the proofs
ChrisHughes24
approved these changes
Jun 11, 2019
butterthebuddha
pushed a commit
to butterthebuddha/mathlib
that referenced
this pull request
May 15, 2020
…rover-community#1126) * feat(group_theory/conjugates) : define conjugates define group conjugates and normal closure * feat(algebra/order_functions): generalize strict_mono.monotone (leanprover-community#1022) * trying to merge * feat(group_theory\presented_group): define presented groups Presented groups are defined as a quotient of a free group by the normal subgroup the relations generate. * feat(group_theory\presented_group): define presented groups Presented groups are defined as a quotient of a free group by the normal subgroup the relations generate * Update src/group_theory/presented_group.lean Co-Authored-By: Keeley Hoek <keeley@hoek.io> * Uniqueness of extension * Tidied up to_group.unique * Removed unnecessary line * Changed naming * refactor(group_theory/abelianization): simplify abelianization The commutator of a group was previously defined using lists. Now it is defined using `normal_closure`. This change simplifies some of the proofs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
I changed
group_theory/abelianizationto usenormal_closure. This makes the proofs shorter. I mentioned these changes to @kckennylau on Zulip https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/Abelianization.