This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(ring_theory/graded_algebra): definition of type class graded_algebra#10115
Closed
jjaassoonn wants to merge 39 commits intomasterfrom
Closed
[Merged by Bors] - feat(ring_theory/graded_algebra): definition of type class graded_algebra#10115jjaassoonn wants to merge 39 commits intomasterfrom
graded_algebra#10115jjaassoonn wants to merge 39 commits intomasterfrom
Conversation
8 tasks
eric-wieser
reviewed
Nov 2, 2021
1 task
eric-wieser
reviewed
Nov 2, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Nov 2, 2021
eric-wieser
reviewed
Nov 2, 2021
1 task
eric-wieser
reviewed
Nov 2, 2021
eric-wieser
reviewed
Nov 2, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…munity/mathlib into graded_ring_dep_2
This was referenced Nov 2, 2021
Member
|
#10127 is an alternative approach to this, which I'm exploring... The nice thing is that it generalizes to graded algebras well. |
eric-wieser
reviewed
Nov 17, 2021
eric-wieser
reviewed
Nov 17, 2021
eric-wieser
reviewed
Nov 17, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Nov 17, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
reviewed
Nov 17, 2021
eric-wieser
reviewed
Nov 25, 2021
|
✌️ jjaassoonn can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
approved these changes
Nov 25, 2021
Member
eric-wieser
left a comment
There was a problem hiding this comment.
bors d+
Sorry for forgetting about this!
Collaborator
Author
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2021
…gebra` (#10115) This is largely written by @eric-wieser. Thank you. Co-authored-by: jjaassoonn <jujian.zhang1998@out.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Collaborator
Author
No worries. Thank you very much! |
|
Pull request successfully merged into master. Build succeeded: |
graded_algebragraded_algebra
ericrbg
pushed a commit
that referenced
this pull request
Nov 27, 2021
…gebra` (#10115) This is largely written by @eric-wieser. Thank you. Co-authored-by: jjaassoonn <jujian.zhang1998@out.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jcommelin
pushed a commit
that referenced
this pull request
Dec 18, 2021
…gebra` (#10115) This is largely written by @eric-wieser. Thank you. Co-authored-by: jjaassoonn <jujian.zhang1998@out.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is largely written by @eric-wieser. Thank you.