This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(algebra/big_operators/finprod): add lemma finprod_mem_finset_of_product#7439
Closed
[Merged by Bors] - feat(algebra/big_operators/finprod): add lemma finprod_mem_finset_of_product#7439
finprod_mem_finset_of_product#7439Conversation
ocfnash
added a commit
that referenced
this pull request
May 2, 2021
I'll tidy this all up after #7439 is resolved.
eric-wieser
reviewed
May 3, 2021
As it happens, I found it more convenient to derive this as a corollary of `finprod_mem_finset_of_product` rather than vice-versa.
257c0b3 to
b039301
Compare
eric-wieser
reviewed
May 3, 2021
We have to accept one of the following compromises: 1. Not having `simp` for `finprod_mem_mul_support` 2. Dropping `simp` from `function.mem_mul_support` 3. Restating `finprod_mem_mul_support` using `h : f a ≠ 1` instead of `a ∈ mul_support f` Probably 3 is the right approach but I'd at least like to see if the changes here are sufficient to get the build passing so I can see what 2 would look like.
This reverts commit db43cf0.
Also dropping `finprod_along_mul_support` since this is now provable `by simp`.
ocfnash
added a commit
that referenced
this pull request
May 6, 2021
The dependence was a legacy of previous proposal.
fpvandoorn
reviewed
May 24, 2021
Member
fpvandoorn
left a comment
There was a problem hiding this comment.
Some comments:
- all
..._of_productnames should be..._productor..._prod(that is the canonical name, but I guess that is confusing in this file). - The subscripts
2should probably be subscripts3, since they are about ternary functions.
Member
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
finprod_mem_finset_of_productfinprod_mem_finset_of_product
YaelDillies
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 9, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only one import could not easily be reversed, namely the one to `Data.Set.Finite`, so I created a new file instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 13, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only two import could not easily be reversed, namely the ones to `Data.Set.Finite` and `Order.ConditionallyCompleteLattice.Basic`, so I created two new files instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
awueth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 19, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only two import could not easily be reversed, namely the ones to `Data.Set.Finite` and `Order.ConditionallyCompleteLattice.Basic`, so I created two new files instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related conversation on Zulip here