This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - feat(data/support): add function.mul_support#6791
Closed
[Merged by Bors] - feat(data/support): add function.mul_support#6791
function.mul_support#6791Conversation
This will help us add `finprod` in #6355
This was referenced Mar 21, 2021
Member
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2021
This will help us add `finprod` in #6355
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2021
This will help us add `finprod` in #6355
|
Pull request successfully merged into master. Build succeeded: |
function.mul_supportfunction.mul_support
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
This will help us add `finprod` in #6355
YaelDillies
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 9, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only one import could not easily be reversed, namely the one to `Data.Set.Finite`, so I created a new file instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 13, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only two import could not easily be reversed, namely the ones to `Data.Set.Finite` and `Order.ConditionallyCompleteLattice.Basic`, so I created two new files instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
awueth
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Dec 19, 2023
`Function.support` is a very basic definition. Nevertheless, it is a pretty heavy import because it imports most objects a `support` lemma can be written about. This PR reverses the dependencies between those objects and `Function.support`, so that the latter can become a much more lightweight import. Only two import could not easily be reversed, namely the ones to `Data.Set.Finite` and `Order.ConditionallyCompleteLattice.Basic`, so I created two new files instead. I credit: * Yury for leanprover-community/mathlib3#6791 * Oliver for leanprover-community/mathlib3#7439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help us add
finprodin #6355