Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(topology/order/lower_topology): Introduce the lower topology on a preorder#17426

Closed
mans0954 wants to merge 185 commits intomasterfrom
lower-topology
Closed

[Merged by Bors] - feat(topology/order/lower_topology): Introduce the lower topology on a preorder#17426
mans0954 wants to merge 185 commits intomasterfrom
lower-topology

Conversation

@mans0954
Copy link
Copy Markdown
Collaborator

@mans0954 mans0954 commented Nov 8, 2022

This PR introduces the lower topology on a preorder. It is shown that the lower topology on a partial order is T₀ and the non-empty complements of the upper closures of finite subsets form a basis.

It is also shown that the lower topology on the product of two order_bot spaces coincides with the product topology of the lower topologies on the component spaces. This is used to show that the inf map (a,b) → a ⊓ b on a complete lattice is continuous.

The motivation for introducing the lower topology to mathlib is that, along with the Scott Topology (topology.omega_complete_partial_order) it is used to define the Lawson topology (Gierz et al, Chapter III).


Open in Gitpod

@YaelDillies
Copy link
Copy Markdown
Collaborator

Since it's been a while,

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Copy Markdown
Collaborator

I have two pending comments above (from a few weeks ago). I'd be happy to see them dealt with before the PR is merged.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 16, 2023
@mans0954
Copy link
Copy Markdown
Collaborator Author

mans0954 commented Jan 16, 2023

I have two pending comments above (from a few weeks ago). I'd be happy to see them dealt with before the PR is merged.

@sgouezel - I think I've expanded everything, but I don't seem to be able to see any comments from you on this PR. Please could you post a direct link to them? Sorry.

All I could find open was this comment #17426 (comment) from @YaelDillies - I'd done this some time ago, but forgot to resolve the thread. I've done that now.

@YaelDillies
Copy link
Copy Markdown
Collaborator

Sébastien, I can't find your comments anymore. I think they have been lost to some force-push.

@mans0954
Copy link
Copy Markdown
Collaborator Author

Sébastien, I can't find your comments anymore. I think they have been lost to some force-push.

I've checked my inbox - if @sgouezel had commented on the PR then I should have received an e-mail notification from GitHub.

Copy link
Copy Markdown
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something must have gone wrong somewhere (probably on my side). Here they are again.

Comment on lines +11 to +12
This file introduces the lower topology on a preorder. It is shown that the lower topology on a
partial order is T₀ and the complements of the upper closures of finite subsets form a basis.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain here what the lower topology here. Ideally, the docstring should be readable by someone who doesn't know the maths. You should also sketch the API here, by explaining that you define a type synonym and giving the main theorems.

Copy link
Copy Markdown
Collaborator Author

@mans0954 mans0954 Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgouezel is this the sort of thing you had in mind? It's hard to say too much about motivation without straying into concepts which aren't yet in mathlib (as far as I know).

mans0954 and others added 2 commits January 17, 2023 07:17
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 19, 2023
@YaelDillies YaelDillies requested a review from sgouezel January 19, 2023 22:29
@sgouezel
Copy link
Copy Markdown
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 21, 2023
bors bot pushed a commit that referenced this pull request Jan 21, 2023
…a preorder (#17426)

This PR introduces the lower topology on a preorder. It is shown that the lower topology on a partial order is T₀ and the non-empty complements of the upper closures of finite subsets form a basis.

It is also shown that the lower topology on the product of two `order_bot` spaces coincides with the product topology of the lower topologies on the component spaces. This is used to show that the inf map `(a,b) → a ⊓ b` on a complete lattice is continuous.

The motivation for introducing the lower topology to mathlib is that, along with the Scott Topology (`topology.omega_complete_partial_order`) it is used to define the Lawson topology (Gierz et al, Chapter III).
@bors
Copy link
Copy Markdown

bors bot commented Jan 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/order/lower_topology): Introduce the lower topology on a preorder [Merged by Bors] - feat(topology/order/lower_topology): Introduce the lower topology on a preorder Jan 21, 2023
@bors bors bot closed this Jan 21, 2023
@bors bors bot deleted the lower-topology branch January 21, 2023 12:48
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 4, 2024
… Mathlib (#11710)

Introduces the Lawson Topology on a preorder.

The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced.

A basis for the Lawson Topology is defined and some basic results are established:

- An upper set is Lawson open if and only if it is Scott open
- A lower set is Lawson closed if and only if it is closed under sups of directed sets
- The Lawson topology on a partial order is T₀ 



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
apnelson1 pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 12, 2024
… Mathlib (#11710)

Introduces the Lawson Topology on a preorder.

The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced.

A basis for the Lawson Topology is defined and some basic results are established:

- An upper set is Lawson open if and only if it is Scott open
- A lower set is Lawson closed if and only if it is closed under sups of directed sets
- The Lawson topology on a partial order is T₀ 



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
callesonne pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 16, 2024
… Mathlib (#11710)

Introduces the Lawson Topology on a preorder.

The Lawson Topology is defined as the meet of the [Lower Topology](leanprover-community/mathlib3#17426) and the [Scott Topology](#2508) previously introduced.

A basis for the Lawson Topology is defined and some basic results are established:

- An upper set is Lawson open if and only if it is Scott open
- A lower set is Lawson closed if and only if it is closed under sups of directed sets
- The Lawson topology on a partial order is T₀ 



Co-authored-by: Christopher Hoskin <mans0954@users.noreply.github.com>
Co-authored-by: Christopher Hoskin <christopher.hoskin@overleaf.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants