[Merged by Bors] - chore(algebra/order): avoid classical.choice in lt_of_le_of_ne#428
Closed
urkud wants to merge 1 commit intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(algebra/order): avoid classical.choice in lt_of_le_of_ne#428urkud wants to merge 1 commit intoleanprover-community:masterfrom
classical.choice in lt_of_le_of_ne#428urkud wants to merge 1 commit intoleanprover-community:masterfrom
Conversation
Copy proof from `lt_of_le_of_ne'` in `mathlib`.
Collaborator
|
Should we add a docstring mentioning that it's there because it avoids classical choice? |
Member
|
If it's replacing the original proof, there probably isn't much need to note this explicitly, unless someone feels like changing the proof again. (It could go in the commit message though.) |
Member
|
Let's appease the intuitionism police. bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
classical.choice in lt_of_le_of_neclassical.choice in lt_of_le_of_ne
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy proof from
lt_of_le_of_ne'inmathlib. The proofwas written by Mario Carneiro.
Co-authored-by: Mario Carneiro di.gama@gmail.com