chore: remove Std.Data.List import from Omega#568
Merged
joehendrix merged 3 commits intomainfrom Feb 1, 2024
Merged
Conversation
digama0
reviewed
Jan 30, 2024
kim-em
reviewed
Jan 30, 2024
Collaborator
kim-em
left a comment
There was a problem hiding this comment.
Looks good to me.
There are lots of theorems in Std.Tactic.Omega.MinNatAbs that are not actually used (they are leftovers from the verified version), but I don't think them removing them actually reduces how much we need to move to Init, in any case.
fgdorais
pushed a commit
to fgdorais/batteries
that referenced
this pull request
Feb 18, 2024
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds lemmas to Std.Data.List from Omega dependencies so that Omega can be used in List lemmas.
I changed a few proofs as part of this to reduce dependencies and include fewer lemmas in Init.