feat: more lemmas about equality#465
Merged
joehendrix merged 4 commits intoleanprover-community:mainfrom Jan 11, 2024
Merged
Conversation
2 tasks
Contributor
Author
|
awaiting-review |
fgdorais
requested changes
Dec 19, 2023
Std/Logic.lean
Outdated
Comment on lines
+743
to
+747
| @[simp] theorem eq_mp_eq_cast (h : α = β) : Eq.mp h = cast h := | ||
| rfl | ||
|
|
||
| @[simp] theorem eq_mpr_eq_cast (h : α = β) : Eq.mpr h = cast h.symm := | ||
| rfl |
Collaborator
There was a problem hiding this comment.
These two theorems should not be simp.
Contributor
There was a problem hiding this comment.
This broke mathlib in a few case. Was that breakage expected?
Contributor
Author
|
awaiting-review |
fgdorais
approved these changes
Dec 20, 2023
fgdorais
reviewed
Dec 28, 2023
Co-authored-by: François G. Dorais <fgdorais@gmail.com>
Contributor
Author
|
awaiting-review |
kim-em
approved these changes
Jan 5, 2024
joehendrix
approved these changes
Jan 10, 2024
Merged
kim-em
reviewed
Jan 11, 2024
Comment on lines
+769
to
+773
| theorem eq_mp_eq_cast (h : α = β) : Eq.mp h = cast h := | ||
| rfl | ||
|
|
||
| theorem eq_mpr_eq_cast (h : α = β) : Eq.mpr h = cast h.symm := | ||
| rfl |
Collaborator
There was a problem hiding this comment.
I'm not thilled about PRs that upstream lemmas but drop @[simp] attributes.
Contributor
There was a problem hiding this comment.
I think that was an oversight. We could add them in a separate PR.
Collaborator
There was a problem hiding this comment.
This was my bad! The issue is that Std doesn't know much what to do with cast, so these simps led "nowhere" in a sense.
A better solution would have been to delete them and wait until better cast support makes it down to Std.
astrainfinita
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Sep 24, 2024
These lemmas were upstreamed to Batteries in leanprover-community/batteries#465.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.