Skip to content

chore: fixes for new simp default (decide := false) (lean4#2722)#312

Merged
digama0 merged 2 commits intoleanprover-community:bump/v4.4.0from
collares:lean-pr-testing-2722
Nov 4, 2023
Merged

chore: fixes for new simp default (decide := false) (lean4#2722)#312
digama0 merged 2 commits intoleanprover-community:bump/v4.4.0from
collares:lean-pr-testing-2722

Conversation

@collares
Copy link
Copy Markdown
Contributor

@collares collares commented Oct 21, 2023

Adapt to new default in Lean master.

@collares collares changed the title chore: fixes simp defaulting to decide := false (lean4#2722) chore: fixes for new simp default (decide := false) (lean4#2722) Oct 21, 2023
@collares collares force-pushed the lean-pr-testing-2722 branch 3 times, most recently from a2657ee to 60a1ddf Compare October 21, 2023 20:59
@kim-em kim-em added the depends on core changes This PR need only be reviewed after changes land in Lean core. label Oct 21, 2023
@kim-em
Copy link
Copy Markdown
Collaborator

kim-em commented Oct 21, 2023

These changes seem pretty reasonable to me.

@collares collares force-pushed the lean-pr-testing-2722 branch from 60a1ddf to ed5610b Compare October 23, 2023 17:26
@collares collares marked this pull request as ready for review October 23, 2023 17:32
@ghost ghost added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 31, 2023
@collares collares force-pushed the lean-pr-testing-2722 branch from ed5610b to 6f724a0 Compare October 31, 2023 06:57
@ghost ghost removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 31, 2023
@kim-em kim-em added the v4.4.0 label Nov 2, 2023
@kim-em kim-em changed the base branch from main to bump/v4.4.0 November 2, 2023 01:51
@collares collares force-pushed the lean-pr-testing-2722 branch from a81cb02 to e930b99 Compare November 2, 2023 07:55
@collares
Copy link
Copy Markdown
Contributor Author

collares commented Nov 2, 2023

awaiting-review

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Nov 2, 2023
@collares collares force-pushed the lean-pr-testing-2722 branch 2 times, most recently from 986f0db to 66f20fc Compare November 3, 2023 08:37
kim-em added a commit that referenced this pull request Nov 3, 2023
@kim-em
Copy link
Copy Markdown
Collaborator

kim-em commented Nov 3, 2023

@digama0, @joehendrix, could this please be reviewed and merged? Note that this will go into the bump/v4.4.0 branch, not main, which is intended to accummulate approved changes that are needed for the next release.

After this is merged I will merge leanprover-community/mathlib4#7834 into Mathlib's bump/v4.4.0 branch as well.

@collares collares force-pushed the lean-pr-testing-2722 branch from 66f20fc to 029d701 Compare November 3, 2023 11:27
@digama0 digama0 merged commit d87522e into leanprover-community:bump/v4.4.0 Nov 4, 2023
@collares collares deleted the lean-pr-testing-2722 branch November 4, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review This PR is ready for review; the author thinks it is ready to be merged. depends on core changes This PR need only be reviewed after changes land in Lean core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants