Skip to content

chore: fixes for lean4#2688#297

Closed
kim-em wants to merge 3 commits intomainfrom
lean-pr-testing-2688
Closed

chore: fixes for lean4#2688#297
kim-em wants to merge 3 commits intomainfrom
lean-pr-testing-2688

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Oct 16, 2023

No description provided.

@kim-em kim-em added the depends on core changes This PR need only be reviewed after changes land in Lean core. label Oct 16, 2023
@ghost ghost added the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 19, 2023
@kim-em kim-em removed the merge-conflict This PR has merge conflicts with the `main` branch which must be resolved by the author. label Oct 22, 2023
@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Oct 23, 2023

I've now merged this into nightly-testing.

It would be good to have approval on this before the next Lean release (next Sunday).

@kim-em kim-em added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Oct 23, 2023
Copy link
Copy Markdown
Member

@digama0 digama0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this when the upstream PR lands

@kim-em kim-em changed the title chore: fixes for lean4#2688 chore: fixes for lean4#2688 [merged into nightly-testing] Oct 25, 2023
@kim-em kim-em added the merged-into-nightly-testing This has been merged into `nightly-testing`, and will join `main` when we update the toolchain. label Oct 25, 2023
@kim-em kim-em changed the title chore: fixes for lean4#2688 [merged into nightly-testing] chore: fixes for lean4#2688 Oct 25, 2023
@digama0 digama0 closed this in 0daeae3 Oct 31, 2023
@digama0 digama0 deleted the lean-pr-testing-2688 branch October 31, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review This PR is ready for review; the author thinks it is ready to be merged. depends on core changes This PR need only be reviewed after changes land in Lean core. merged-into-nightly-testing This has been merged into `nightly-testing`, and will join `main` when we update the toolchain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants