chore(Tactic/Lint/Simp): add local hypotheses to simp context#1214
Closed
chore(Tactic/Lint/Simp): add local hypotheses to simp context#1214
Conversation
This PR adds the local hypotheses to the simp context when checking simp-normal form. That means we effectively test if `simp [*]` will rewrite the left-hand side to the right-hand side, instead of just `simp` (or `dsimp` in the case of rfl theorems).
Contributor
|
I noticed you removed the use of It is quite likely that a bunch of errors will appear in Mathlib after this. We'll have to wait and see if they are all correct errors. |
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 28, 2025
|
Mathlib CI status (docs):
|
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 29, 2025
Collaborator
|
Looks like this one got lost in the queue... Could you fix the merge conflicts before I have a look? |
Contributor
|
This PR was superseded by #1220, so it can now be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the local hypotheses to the simp context when checking simp-normal form.
That means we effectively test if
simp [*]will rewrite the left-hand side to the right-hand side,instead of just
simp(ordsimpin the case of rfl theorems).