Skip to content

feat: add further API about Lean.NameSet#1091

Merged
kim-em merged 1 commit intoleanprover-community:mainfrom
grunweg:MR-nameset-api
Jan 9, 2025
Merged

feat: add further API about Lean.NameSet#1091
kim-em merged 1 commit intoleanprover-community:mainfrom
grunweg:MR-nameset-api

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Jan 9, 2025

Taken from ImportGraph; originally written by kim-em.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 9, 2025

awaiting-review

@github-actions github-actions bot added the awaiting-review This PR is ready for review; the author thinks it is ready to be merged. label Jan 9, 2025
Taken from ImportGraph; originally written by .
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jan 9, 2025
@ghost ghost added the breaks-mathlib label Jan 9, 2025
@ghost
Copy link
Copy Markdown

ghost commented Jan 9, 2025

Mathlib CI status (docs):

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 9, 2025

The mathlib build fails, because ImportGraph defines the same API. Imho, the correct way forward is to

@kim-em kim-em added this pull request to the merge queue Jan 9, 2025
Merged via the queue into leanprover-community:main with commit 66225aa Jan 9, 2025
@grunweg grunweg deleted the MR-nameset-api branch January 9, 2025 22:52
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Jan 9, 2025

Step 2 proposed upstream: merging that/commenting on a different strategy is welcome :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review This PR is ready for review; the author thinks it is ready to be merged. breaks-mathlib

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants