Skip to content

fix: use replay from leanprover/lean4#2617#71

Closed
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:use_replay
Closed

fix: use replay from leanprover/lean4#2617#71
kim-em wants to merge 1 commit intoleanprover-community:masterfrom
kim-em:use_replay

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Oct 9, 2023

This is only relevant after leanprover/lean4#2617 is merged.

This PR uses Environment.replay instead of the playing-with-fire Environment.add which we would like to make private.

@JLimperg
Copy link
Copy Markdown
Collaborator

I'm really looking forward to getting rid of this hack. Thank you for your work on this!

kim-em added a commit to kim-em/aesop that referenced this pull request Oct 13, 2023
@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Oct 16, 2023

Closed, this was rolled into #71.

@kim-em kim-em closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants