chore: remove the redundant include: #stringBlock in lean4 syntax#623
Merged
mhuisi merged 1 commit intoleanprover:masterfrom Jun 9, 2025
Merged
chore: remove the redundant include: #stringBlock in lean4 syntax#623mhuisi merged 1 commit intoleanprover:masterfrom
include: #stringBlock in lean4 syntax#623mhuisi merged 1 commit intoleanprover:masterfrom
Conversation
`#stringBlock` was added in 48ad018 on 2020-06-23, when people were developing in the legacy vscode-lean repo. Later, `#stringBlock` was removed in ca65431 on 2021-01-18 when migrating from lean 3 to lean 4. However, the `include` line was forgotten. In fact, VS Code’s parser (vscode-textmate) will tolerate missing includes, so the original syntax works.
YDX-2147483647
added a commit
to YDX-2147483647/bat
that referenced
this pull request
Jun 9, 2025
Resolves sharkdp#3286 1. `lean4.json` → `lean4.tmLanguage` 1. Download `vscode-lean4/syntaxes/lean4.json` from leanprover/vscode-lean4#623. 2. Install the VS Code extension [TextMate Languages (pedro-w)](https://marketplace.visualstudio.com/items?itemName=pedro-w.tmlanguage). 3. Open `lean4.json` in VS Code, <kbd>F1</kbd>, and “Convert to tmLanguage PLIST File”. 2. `lean4.tmLanguage` → `lean4.sublime-syntax` Open `lean4.tmLanguage` in Sublime text, “Tools → Developer → New Syntax from lean4.tmLanguage…”.
Collaborator
|
Thanks! |
include: #stringBlock in lean4 syntaxinclude: #stringBlock in lean4 syntax
YDX-2147483647
added a commit
to YDX-2147483647/bat
that referenced
this pull request
Jun 10, 2025
Resolves sharkdp#3286 1. `lean4.json` → `lean4.tmLanguage` 1. Download `vscode-lean4/syntaxes/lean4.json` from leanprover/vscode-lean4#623 (now merged). 2. Install the VS Code extension [TextMate Languages (pedro-w)](https://marketplace.visualstudio.com/items?itemName=pedro-w.tmlanguage). 3. Open `lean4.json` in VS Code, <kbd>F1</kbd>, and “Convert to tmLanguage PLIST File”. 2. `lean4.tmLanguage` → `lean4.sublime-syntax` Open `lean4.tmLanguage` in Sublime text, “Tools → Developer → New Syntax from lean4.tmLanguage…”.
YDX-2147483647
added a commit
to YDX-2147483647/bat
that referenced
this pull request
Jun 10, 2025
Resolves sharkdp#3286 1. `lean4.json` → `lean4.tmLanguage` 1. Download `vscode-lean4/syntaxes/lean4.json` from leanprover/vscode-lean4#623 (now merged). 2. Install the VS Code extension [TextMate Languages (pedro-w)](https://marketplace.visualstudio.com/items?itemName=pedro-w.tmlanguage). 3. Open `lean4.json` in VS Code, <kbd>F1</kbd>, and “Convert to tmLanguage PLIST File”. 2. `lean4.tmLanguage` → `lean4.sublime-syntax` Open `lean4.tmLanguage` in Sublime text, “Tools → Developer → New Syntax from lean4.tmLanguage…”.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#stringBlockis a block in the lean 3 / lean 4 syntax file, and it was added in 48ad018 on 2020-06-23, when people were developing in the legacy vscode-lean repo.Later,
#stringBlockwas removed in ca65431 on 2021-01-18 when migrating from lean 3 to lean 4.Somehow, the
includeline was forgotten. This PR now removes the line.In fact, VS Code’s parser (vscode-textmate) will tolerate missing includes, so the original syntax works.
(You could verify it by amending
~/.vscode/extensions/leanprover.lean4-0.0.207/syntaxes/lean4.jsonand reloading the VS Code window.)However, including the inexistent
#stringBlockwill cause problems for a downstream project.If you are concerned about the details, please refer to sharkdp/bat#3286.