feat: different syntax for new clear_value tactic#8516
Merged
kmill merged 2 commits intoleanprover:masterfrom May 28, 2025
Merged
feat: different syntax for new clear_value tactic#8516kmill merged 2 commits intoleanprover:masterfrom
clear_value tactic#8516kmill merged 2 commits intoleanprover:masterfrom
Conversation
sgraf812
reviewed
May 28, 2025
Contributor
sgraf812
left a comment
There was a problem hiding this comment.
Just found a typo; resisted the temptation to do a full code review on PTO :)
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 28, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 28, 2025
|
Mathlib CI status (docs):
|
kmill
commented
May 28, 2025
This PR is a followup to leanprover#8449 to refine the syntax of `clear_value`. Now the syntax for adding equality hypotheses before clearing values is `clear_value (h : x = _)`. This syntax was developed in a [Zulip discussion](https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/.60clear_value.60.20syntax.20request.20for.20comments/near/520704290).
020a2c9 to
5d1268d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #8449 to refine the syntax of
clear_value. The syntax for adding equality hypotheses before clearing values is nowclear_value (h : x = _). Any expression definitionally equal toxcan be used in place of the underscore.This syntax was developed in a Zulip discussion.