feat: revamp aux decl name generation#8363
Merged
Kha merged 2 commits intoleanprover:masterfrom May 16, 2025
Merged
Conversation
Rob23oba
reviewed
May 15, 2025
eba1110 to
73c2555
Compare
Member
Author
|
@JLimperg Could you test whether this can be used to resolve the aesop+omega issue? You'd need to use |
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 16, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2025
|
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 16, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2025
|
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unifies various ways of naming auxiliary declarations in a conflict-free way and ensures the method is compatible with diverging branches of elaboration such as parallelism or Aesop-like backtracking+replaying search.