Skip to content

feat: use NeZero in Fin lemmas where possible#8291

Merged
kim-em merged 1 commit intomasterfrom
fin_nezero
May 12, 2025
Merged

feat: use NeZero in Fin lemmas where possible#8291
kim-em merged 1 commit intomasterfrom
fin_nezero

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented May 12, 2025

This PR changes the statements of Fin lemmas to use [NeZero n] (i : Fin n) rather than (i : Fin (n+1)) where possible.

@kim-em kim-em added awaiting-mathlib We should not merge this until we have a successful Mathlib build changelog-library Library labels May 12, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 12, 2025
ghost pushed a commit to leanprover-community/batteries that referenced this pull request May 12, 2025
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request May 12, 2025
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 12, 2025
@ghost
Copy link
Copy Markdown

ghost commented May 12, 2025

@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels May 12, 2025
@ghost
Copy link
Copy Markdown

ghost commented May 12, 2025

@kim-em kim-em added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 7f6f4c8 May 12, 2025
32 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant