chore: improve application type mismatch error message#8264
Merged
Conversation
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 8, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 8, 2025
|
Mathlib CI status (docs):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewords the
application type mismatcherror message by more specifically mentioning that the problem is with the final argument. This is useful when the same argument is passed to the function multiple times.We decided against using a wording which specifically mentions the "function expression", because users who are not used to currying might not think of the
f ainf a bas a function.