chore: more verbose tests & related fixes#8183
Merged
tydeu merged 9 commits intoleanprover:masterfrom May 1, 2025
Merged
Conversation
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 30, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 30, 2025
05f270d to
d214966
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 30, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 30, 2025
|
Mathlib CI status (docs):
|
d209b25 to
f12668a
Compare
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 1, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Lake tests much more verbose in output. It also fixes some bugs that had been missed due to disabled tests. Most significantly, the target specifier
@pkg(e.g., inlake build) is now always interpreted as a package. It was previously ambiguously interpreted due to changes in #7909.