feat: use BaseIO at MonadLift (ST IO.RealWorld)#772
Merged
Kha merged 1 commit intoleanprover:masterfrom Nov 9, 2021
Merged
Conversation
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 11, 2021
Bumps to the Lean 4 nightly from 2021-11-10, and cleans up `Cache.lean` post leanprover/lean4#772. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
ChrisHughes24
added a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
SHA 19091d8f2e537e76a81d1608e011dd4d03f94642 Finished the port Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves type inference for lifting the monad (see, for example, PR #86 of mathlib4). It also just simplifies the instance.
I looked for any other uses of
EIO εthat could use cleanup now thatBaseIOexists. The only other relevant usage I found was inLean.Util.Profile. UsingBaseIOforprofileitIOthere could potentially resolve the 'impossible to inferεconcern' mentioned in the comments. However, that is a rather distinct change from this one so I didn't include it here.