feat: finite type conversions (Nat/Int/Fin/BitVec -> IntX -> *)#7368
Merged
feat: finite type conversions (Nat/Int/Fin/BitVec -> IntX -> *)#7368
Nat/Int/Fin/BitVec -> IntX -> *)#7368Conversation
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Mar 6, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Mar 6, 2025
|
Mathlib CI status (docs):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
This PR adds lemmas about `Int` that will be required in #7368. Most notably, we add ```lean @[simp] theorem neg_nonpos_iff (i : Int) : -i ≤ 0 ↔ 0 ≤ i ``` which causes some breakage but gets us closer to mathlib which has a more general version of this that applies to `Int`. Note also that the mathlib adaptation branch deletes the (unused in mathlib) mathib lemma `Int.zero_le_ofNat` as there is now a syntactically different (but definitionally equal) `Int.zero_le_ofNat` in core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds lemmas for iterated conversions between finite types, starting with something of type
Nat/Int/Fin/BitVecand going throughIntX.