Skip to content

chore: repair defeqs for List GetElem instances#7121

Merged
kim-em merged 2 commits intomasterfrom
repair_list_defeqs
Feb 18, 2025
Merged

chore: repair defeqs for List GetElem instances#7121
kim-em merged 2 commits intomasterfrom
repair_list_defeqs

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Feb 18, 2025

This PR repairs some defeq breakages from #7059.

@kim-em kim-em requested a review from digama0 as a code owner February 18, 2025 01:53
@kim-em kim-em enabled auto-merge February 18, 2025 01:56
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 18, 2025 02:05 Inactive

/-! ### getElem?-/

/-- Internal implementation of `as[i]?`. Do not use directly. -/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe private?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll try that out now.

@kim-em kim-em added this pull request to the merge queue Feb 18, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 18, 2025
@ghost
Copy link
Copy Markdown

ghost commented Feb 18, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2cdf4b14e14220e9c5a434c0365d5e996fc38e75 --onto 88664e4a995883877a5d85211a5cfab0a672b5ed. (2025-02-18 02:23:20)

auto-merge was automatically disabled February 18, 2025 02:27

Pull Request is not mergeable

Merged via the queue into master with commit ca253ae Feb 18, 2025
13 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants