feat: record all structure parents in StructureInfo#5853
Merged
kmill merged 1 commit intoleanprover:masterfrom Oct 28, 2024
Merged
feat: record all structure parents in StructureInfo#5853kmill merged 1 commit intoleanprover:masterfrom
StructureInfo#5853kmill merged 1 commit intoleanprover:masterfrom
Conversation
|
Mathlib CI status (docs):
|
Followup to leanprover#5841. Makes the `structure` command populate the new `parentInfo` field. This will require a stage0 update to fully take effect. Breaking change: now `getParentStructures` is `getStructureSubobjects`. Adds `getStructureParentInfo` for getting all the immediate parents. Note that the set of subobjects is neither a subset nor a superset of the immediate parents. Closes leanprover#1881
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 28, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 28, 2024
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #5841. Makes the
structurecommand populate the newparentInfofield with all the structures in theextendsclause.This will require a stage0 update to fully take effect.
Breaking change: now it's a warning if a structure extends a parent multiple times.
Breaking change: now
getParentStructuresisgetStructureSubobjects. AddsgetStructureParentInfofor getting all the immediate parents. Note that the set of subobjects is neither a subset nor a superset of the immediate parents.Closes #1881