Merged
Conversation
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 5, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 5, 2024
|
Mathlib CI status (docs):
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 5, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 5, 2024
nomeata
reviewed
Feb 5, 2024
Collaborator
nomeata
left a comment
There was a problem hiding this comment.
I expect that this will, as a side effect, fix most (but not all) instances of #3245.
One could make simpIfTarget even more robust if it receives as a parameter the name of the hypotheses actually added by split, and discharge could simply use precisely that, instead of going through the local context. Not sure if it’s worth it, or if maybe using any available hypothesis is actually desirable here.
Co-authored-by: Joachim Breitner <mail@joachim-breitner.de>
Collaborator
|
Mathlib fix is trivial, CI should go green shortly. |
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Feb 6, 2024
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 6, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 7, 2024
…n split tactic) (#10328) Adaptation PR for leanprover/lean4#3258, which fixes leanprover/lean4#3229. --- <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. To indicate co-authors, include lines at the bottom of the commit message (that is, before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [](https://gitpod.io/from-referrer/) --------- Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 7, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 7, 2024
…n split tactic) (#10330) This was previously #10328, but I merged this into `master`, not `bump/v4.7.0`. 🤦♀️ Trying again. --- <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. To indicate co-authors, include lines at the bottom of the commit message (that is, before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [](https://gitpod.io/from-referrer/) --------- Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
atarnoam
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 9, 2024
…n split tactic) (#10328) Adaptation PR for leanprover/lean4#3258, which fixes leanprover/lean4#3229. --- <!-- The text above the `---` will become the commit message when your PR is merged. Please leave a blank newline before the `---`, otherwise GitHub will format the text above it as a title. To indicate co-authors, include lines at the bottom of the commit message (that is, before the `---`) using the following format: Co-authored-by: Author Name <author@email.com> Any other comments you want to keep out of the PR commit should go below the `---`, and placed outside this HTML comment, or else they will be invisible to reviewers. If this PR depends on other PRs, please list them below this comment, using the following format: - [ ] depends on: #abc [optional extra text] - [ ] depends on: #xyz [optional extra text] --> [](https://gitpod.io/from-referrer/) --------- Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com>
atarnoam
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Feb 9, 2024
This was referenced Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3229