fix: version numbers in code actions#2721
Merged
kim-em merged 1 commit intoleanprover:masterfrom Oct 24, 2023
bustercopley:code-action-document-version
Merged
fix: version numbers in code actions#2721kim-em merged 1 commit intoleanprover:masterfrom bustercopley:code-action-document-version
kim-em merged 1 commit intoleanprover:masterfrom
bustercopley:code-action-document-version
Conversation
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 20, 2023
|
This was referenced Oct 20, 2023
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 22, 2023
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Zulip topic, #306(Std).
VS Code ignores the version number in a WorkspaceEdit but does not allow it to be null. There is at least one LSP client which does validate the version number, namely the Eglot client included in Emacs. By sending the correct version, we can be compatible with both.