chore: simp tracing reports ←#2621
Merged
kim-em merged 5 commits intoleanprover:masterfrom Oct 15, 2023
Merged
Conversation
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 4, 2023
|
Collaborator
Author
|
@digama0 if it's useful for reviewing I can make proposed downstream changes to Std and Mathlib as well, but won't immediately unless you say so. |
Collaborator
Author
|
@digama0, I'd like to get this in, but am uncertain whether your self-assignment above means:
|
Collaborator
|
It means I was planning on reviewing it, but I was at a conference last week so I'm just now working down my backlog. I'll take a look at it now or tomorrow. |
digama0
reviewed
Oct 10, 2023
digama0
reviewed
Oct 10, 2023
digama0
approved these changes
Oct 10, 2023
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 10, 2023
kim-em
added a commit
to kim-em/std4
that referenced
this pull request
Oct 13, 2023
kim-em
added a commit
to kim-em/aesop
that referenced
this pull request
Oct 13, 2023
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
Co-authored-by: Mario Carneiro <di.gama@gmail.com>
a8dbbdb to
517a412
Compare
Collaborator
Author
|
Phew, lots of downstream changes required for this one: |
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 13, 2023
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 13, 2023
Collaborator
Author
|
I've checked that downstream projects survive okay. There is some unfortunate copypasta there that ideally we can clean up later. |
digama0
approved these changes
Oct 14, 2023
kim-em
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 16, 2023
* chore: adapt to leanprover/lean4#2621 * bump to v4.2.0-rc2
kim-em
added a commit
to leanprover-community/aesop
that referenced
this pull request
Oct 16, 2023
* fix: use replay from leanprover/lean4#2617 * chore: adapt to leanprover/lean4#2621 * bump to v4.2.0-rc2
thorimur
pushed a commit
to thorimur/batteries
that referenced
this pull request
Oct 23, 2023
thorimur
pushed a commit
to thorimur/batteries
that referenced
this pull request
Oct 23, 2023
thorimur
pushed a commit
to thorimur/batteries
that referenced
this pull request
Oct 24, 2023
thorimur
pushed a commit
to thorimur/batteries
that referenced
this pull request
Oct 24, 2023
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2131 and leanprover-community/batteries#264