chore: change simp default to decide := false#2166
Closed
kim-em wants to merge 0 commit intoleanprover:masterfrom
Closed
chore: change simp default to decide := false#2166kim-em wants to merge 0 commit intoleanprover:masterfrom
kim-em wants to merge 0 commit intoleanprover:masterfrom
Conversation
Collaborator
Author
|
Definitely not working out of the box. :-) I'll try again later. |
Member
|
You're not the first one to notice that this requires more than changing the default. 😄 #2068 FWIW I think false is the right default. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1888 we turned off
decide := trueas the default behaviour indsimp.I think at the time my intent had been to turn this off in
simpas well, but that's not what the PR did.Since then issue #2068 (see also related zulip thread) requested that we turn it off in
simpas well.I will compile mathlib against this PR in case of regressions there.