change default value of decide in simp config#2068
Closed
hrmacbeth wants to merge 1 commit intoleanprover:masterfrom
hrmacbeth:patch-1
Closed
change default value of decide in simp config#2068hrmacbeth wants to merge 1 commit intoleanprover:masterfrom hrmacbeth:patch-1
hrmacbeth wants to merge 1 commit intoleanprover:masterfrom
hrmacbeth:patch-1
Conversation
Contributor
|
Thanks for your contribution! Please make sure to follow our Commit Convention. |
Collaborator
1 task
Contributor
Author
|
Closing now that an alternative PR for this has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1888, @semorrison changed the default value of
decidein the dsimp config fromtruetofalse. This is a proposal to do the same for simp.Perhaps this is a controversial change, so one anecdote: this is currently interacting with another issue (which I think @digama0 will record separately) to make the following
simptake 3 seconds, more than 10x as long assimp (config := { decide := false }).Of course, that other issue should also be fixed, and/or
Ratshould be designed differently to avoid it, but it seems like users will write inefficient decidability instances often enough that the same point of confusion will occur again.