fix: match discriminant reduction should not unfold irreducible defs#2162
Merged
leodemoura merged 1 commit intoleanprover:masterfrom Apr 11, 2023
Merged
fix: match discriminant reduction should not unfold irreducible defs#2162leodemoura merged 1 commit intoleanprover:masterfrom
match discriminant reduction should not unfold irreducible defs#2162leodemoura merged 1 commit intoleanprover:masterfrom
Conversation
Member
Author
|
Perhaps a cleaner approach would be to first call |
hrmacbeth
reviewed
Mar 22, 2023
| let d := Nat.gcd a.num 1 | ||
| ⟨(a.num.div d) * (b.num.div d)⟩ | ||
|
|
||
| example : ((Foo.mul 4 1).mul 1).mul 1 = 4 := by decide |
Contributor
There was a problem hiding this comment.
This fails both before and after this PR, but it goes from failing slowly to failing quickly. Is there a way to put a heartbeat limit on the test?
Contributor
There was a problem hiding this comment.
I think you put the heartbeat limit on the wrong test!
Member
Author
There was a problem hiding this comment.
Yikes, thanks again. Now it's on both.
4bc939d to
a9eedb7
Compare
gebner
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems like a simple oversight to me: none of the functions special-cased in
canUnfoldAtMatcherare irreducible (and it would be quite weird if they were). Likewise, Mixing[match_pattern]and[irreducible]seems inadvisable.Fixes #2161