chore: deprecate String.toSubstring#11232
Merged
TwoFX merged 2 commits intoleanprover:masterfrom Nov 18, 2025
Merged
Conversation
Collaborator
|
Reference manual CI status:
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 18, 2025
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Nov 18, 2025
|
Mathlib CI status (docs):
|
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 18, 2025
ghost
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Nov 18, 2025
kim-em
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Nov 23, 2025
* Update lean-toolchain for testing leanprover/lean4#11232 * A few fixes * Update lean-toolchain for leanprover/lean4#11232 * Update lean-toolchain for testing leanprover/lean4#11180 * lake update * Fix * Fixed Cli * Fix cache and tests * chore: bump to nightly-2025-11-19 * lake update * deprecations * fix merge * lake update proofwidgets * lake update aesop * some `grind +revert` * chore: bump to nightly-2025-11-20 * lake update batteries * grind +revert * chore: adaptations for nightly-2025-11-20 * add grind regression test * chore: bump to nightly-2025-11-21 * chore: adaptations for nightly-2025-11-21 * lake update --------- Co-authored-by: leanprover-community-mathlib4-bot <leanprover-community-mathlib4-bot@users.noreply.github.com> Co-authored-by: Markus Himmel <markus@lean-fro.org> Co-authored-by: Kim Morrison <kim@tqft.net> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: mathlib4-bot <github-mathlib4-bot@leanprover.zulipchat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
String.toSubstringin favor ofString.toRawSubstring(cf. #11154).