Skip to content

feat: use unicode(...) in Init/Notation and elsewhere#10384

Merged
kmill merged 4 commits intoleanprover:masterfrom
kmill:kmill_1056_4
Mar 9, 2026
Merged

feat: use unicode(...) in Init/Notation and elsewhere#10384
kmill merged 4 commits intoleanprover:masterfrom
kmill:kmill_1056_4

Conversation

@kmill
Copy link
Copy Markdown
Collaborator

@kmill kmill commented Sep 15, 2025 •
edited
Loading

This PR makes notations such as ∨, ∧, ≤, and ≥ pretty print using ASCII versions when pp.unicode is false.

Continuation of #10373. Closes #1056.

This will require followup with a stage0 update and removal of the ASCII-only <= and >= syntaxes from Init.Notation, for cleanup.

@kmill kmill added the changelog-pp Pretty printing label Sep 15, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 15, 2025
@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2025

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 22a4cab8c72279f922d8f6fde22739244d5be90b --onto 7e9ea00ac002761b3e040c593cc28a122861ff11. You can force Mathlib CI using the force-mathlib-ci label. (2025-09-15 07:57:02)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

leanprover-bot commented Sep 15, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 22a4cab8c72279f922d8f6fde22739244d5be90b --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-09-15 07:57:03)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2026-03-05 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2026-03-09 01:30:15)

@Rob23oba
Copy link
Copy Markdown
Contributor

Rob23oba commented Nov 17, 2025

Is there a reason this hasn't been merged? (just found this again by looking through old issues)

sgraf812
sgraf812 reviewed Nov 17, 2025
View reviewed changes
kmill added 3 commits March 8, 2026 16:54
@kmill
feat: use unicode(...) in Init/Notation and elsewhere
4dae8e7 
This PR makes notations such as `∨`, `∧`, `≤`, and `≥` pretty print using ASCII versions when `pp.unicode` is false.

Continuation of leanprover#10373. Closes leanprover#1056.
@kmill
update test
98e283c
@kmill
more unicode opportunities, fixed notation typo, remove grind changes…
4823fc6 
… for now
mathlib-nightly-testing bot pushed a commit to leanprover-community/batteries that referenced this pull request Mar 9, 2026
Update lean-toolchain for testing leanprover/lean4#10384
03379aa
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Mar 9, 2026
mathlib-nightly-testing bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Mar 9, 2026
Update lean-toolchain for testing leanprover/lean4#10384
8c1ce5c
@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Mar 9, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Mar 9, 2026

Mathlib CI status (docs):

@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Mar 9, 2026

Mathlib CI status (docs):

@mathlib-lean-pr-testing mathlib-lean-pr-testing bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Mar 9, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Mar 9, 2026

Mathlib CI status (docs):

Rob23oba
Rob23oba reviewed Mar 9, 2026
View reviewed changes
kmill
kmill commented Mar 9, 2026
View reviewed changes
mathlib-nightly-testing bot pushed a commit to leanprover-community/batteries that referenced this pull request Mar 9, 2026
Update lean-toolchain for leanprover/lean4#10384
da42c7f
mathlib-nightly-testing bot pushed a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Mar 9, 2026
Update lean-toolchain for leanprover/lean4#10384
c5a113d
@mathlib-lean-pr-testing
Copy link
Copy Markdown

mathlib-lean-pr-testing bot commented Mar 9, 2026

Mathlib CI status (docs):

@kmill kmill added this pull request to the merge queue Mar 9, 2026
Merged via the queue into leanprover:master with commit 71ff366 Mar 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgraf812 sgraf812 sgraf812 left review comments

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

+1 more reviewer

@Rob23oba Rob23oba Rob23oba left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-pp Pretty printing mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add set_option pp.unicode false

4 participants

@kmill @leanprover-bot @Rob23oba @sgraf812