Skip to content

Events#12

Merged
theinterestedr1 merged 3 commits into
mainfrom
events
Apr 3, 2022
Merged

Events#12
theinterestedr1 merged 3 commits into
mainfrom
events

Conversation

@theinterestedr1

Copy link
Copy Markdown
Contributor

added events on important concensus updates, param changes, user/servicer staking/unstaking, we already had on proof of work and on epoch start

@theinterestedr1 theinterestedr1 merged commit 881c4b3 into main Apr 3, 2022
shleikes pushed a commit that referenced this pull request Dec 1, 2024
NadavLevi added a commit that referenced this pull request Mar 16, 2026
cacheLatencyHistogram was observing latency for both cache hits and misses,
conflating two completely different distributions (memory lookup vs network
call). Wrap the Observe call in if hit {} in both managers. Update test name
and assertion to reflect the new behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NadavLevi added a commit that referenced this pull request Mar 16, 2026
Addresses all issues raised in code review (issues #1–9, #11–19):

Correctness:
- Add apiInterface label to endpointSelectionScore gauge and propagate it
  through SetProviderSelected interface and all call sites (#4)
- Align SetRelayNodeErrorMetric parameter order to (chainId, apiInterface,
  providerAddress, method) — was (providerAddress, chainId, apiInterface) (#7)
- Scope metric setters outside the lock in RegisterEndpoint to avoid
  re-entrant RWMutex deadlock (#11)
- Record cache latency histogram only on cache hits, not misses (#12)
- Remove dead field MeasureAfterProviderProcessingTime from RelayMetrics
  and its sole write site (#14)

Dead code:
- Remove dead stubs SetRelaySentToProviderMetric and SetRequestPerProvider
  from SmartRouterMetricsManager (#5)
- Delete empty consumer_metrics_manager_test.go (#18)

Simplification:
- Replace bespoke registerMetric closure with generic registerOrReuse
  helper throughout ConsumerMetricsManager (#6)
- Unify latency histogram buckets via shared LatencyBuckets variable in
  buckets.go — removes per-file duplicates (#8)
- Drop unnecessary goroutine spawns from RPCConsumerLogs metric forwarders;
  callers already run in goroutines where needed (#9)
- Replace RequestProperties struct with *RelayMetrics in RecordDirectRelayEnd,
  eliminating a duplicate of the same fields (#15)

Documentation:
- Document the request-group counting invariants in SetRelayMetrics (#13)
- Add comment explaining why UpdateHealthcheckStatusBreakdown is a no-op
  in SmartRouterMetricsManager (#16)
- Fix struct comment to list all four labels including apiInterface (#17)

Tests:
- Scope gomock.Controller to each subtest in TestIsArchiveRequest,
  TestIsDebugOrTraceRequest, and TestIsBatchRequest (#19)
- Add TestConsumerSetRelayMetrics_PartitionInvariant asserting
  batch+read+write==total and success+failed==total (#13)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant