Skip to content

ci: pin foundry to fix issues in test running an anvil node#1372

Closed
alvrs wants to merge 10 commits into
mainfrom
alvrs/empty-commit
Closed

ci: pin foundry to fix issues in test running an anvil node#1372
alvrs wants to merge 10 commits into
mainfrom
alvrs/empty-commit

Conversation

@alvrs

@alvrs alvrs commented Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member
  • Tests are suddenly failing on new PRs without related changes. The purpose of this PR is to investigate the reason.

See https://github.com/latticexyz/mud/actions/runs/6025236361/job/16345515615#step:9:45
CleanShot 2023-08-30 at 15 08 17@2x

Edit: fixed by pinning foundry to bff4ed912bb023d7bf9b20eda581aa4867a1cf70, see foundry-rs/foundry#5749

@changeset-bot

changeset-bot Bot commented Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3d2c1cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs changed the title test: fix CI actions ci: pin foundry to fix issues in test running an anvil node Aug 30, 2023
@alvrs alvrs mentioned this pull request Aug 30, 2023
Closed
2 tasks
@alvrs alvrs marked this pull request as ready for review August 30, 2023 14:17
@alvrs alvrs requested a review from frolic as a code owner August 30, 2023 14:17
@alvrs alvrs requested a review from dk1a August 30, 2023 14:18
@alvrs alvrs mentioned this pull request Aug 30, 2023
Merged
@alvrs

alvrs commented Aug 30, 2023

Copy link
Copy Markdown
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alvrs alvrs mentioned this pull request Aug 30, 2023
Merged
dk1a
dk1a previously approved these changes Aug 30, 2023
View reviewed changes
@alvrs

alvrs commented Aug 31, 2023

Copy link
Copy Markdown
Member Author

Closing this since the issue has been fixed upstream and no pinning is necessary anymore

@alvrs alvrs closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frolic frolic Awaiting requested review from frolic

1 more reviewer

@dk1a dk1a dk1a left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alvrs @dk1a