fix(cli): make mud test exit with code 1 on test error#1371
Merged
Conversation
alvrs
commented
Aug 30, 2023
Member
- Currently the process always exits with code 0, so CIs can't detect the script failure. Now the script exits with code 1 in case of an error.
🦋 Changeset detectedLatest commit: ae545eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7965959 to
583ca13
Compare
Member
Author
|
Tests are now correctly failing, see https://github.com/latticexyz/mud/actions/runs/6026182046/job/16348529068?pr=1371#step:9:196 |
Member
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 30, 2023
dk1a
previously approved these changes
Aug 31, 2023
9483d3e to
8d8c89e
Compare
Member
Author
|
merging since no code change since last approval |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.