[MRG]: FIX Quicksort + Cache friendly PresortBestSplitter#6
Merged
larsmans merged 4 commits intolarsmans:tree-sortfrom Jan 25, 2014
Merged
[MRG]: FIX Quicksort + Cache friendly PresortBestSplitter#6larsmans merged 4 commits intolarsmans:tree-sortfrom
larsmans merged 4 commits intolarsmans:tree-sortfrom
Conversation
Author
|
Feel free to merge this in. I won't make any more change. |
Owner
|
Wow, thanks! I'm not sure if deleting the heapsort is a good idea at this point, as we might want to back off to it. |
Author
Indeed, this may still be useful for our benchmarks. I amended my last commit and put heapsort back in. |
|
@larsmans can you merge this one in the original PR? or do you have any concerns? |
Owner
|
No concerns, just little time. I don't get paid to hack on scikit-learn. |
larsmans
added a commit
that referenced
this pull request
Jan 25, 2014
[MRG]: FIX Quicksort + Cache friendly PresortBestSplitter
larsmans
pushed a commit
that referenced
this pull request
Apr 1, 2014
nitpick fixes, pep8 and fix math equations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.