[11.x] prefer new Collection() over collect()#53563
Merged
taylorotwell merged 3 commits intolaravel:11.xfrom Nov 18, 2024
Merged
[11.x] prefer new Collection() over collect()#53563taylorotwell merged 3 commits intolaravel:11.xfrom
new Collection() over collect()#53563taylorotwell merged 3 commits intolaravel:11.xfrom
Conversation
Contributor
Author
|
great. I'll get to work tonight on replacing the remaining occurrences. |
Contributor
|
@browner12 doing gods work |
This comment was marked as resolved.
This comment was marked as resolved.
browner12
added a commit
to browner12/framework
that referenced
this pull request
Mar 17, 2025
this is a continuation of laravel#53563
taylorotwell
added a commit
that referenced
this pull request
Mar 18, 2025
Contributor
|
Also code analyzers can better reason about empty new Collection() then collect(), so thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
collect()helper is a basic wrapper fornew Collection(). because there is no logic in the helper, I believe the framework should internally only usenew Collection().I'm guessing the general sentiment will be "it's fine", and I understand the performance hit is miniscule. However, I believe the framework should avoid aliases and no-logic helpers to try and have the shortest and most performant call graph it can.
this also makes DX slightly better when navigating the framework as you don't have a middleman to click through.
There is A LOT of usage of
collect()in this repo. I've included a good chunk of them in this PR, but didn't want to commit the time until a decision is made on it, but will do so if it's accepted.