Skip to content

replace fixed size takenbuffer with linked list#96

Merged
dqii merged 4 commits intolanterndata:@di/linked-list-bufferfrom
ezra-varady:ezra/linked-list-buffer
Sep 3, 2023
Merged

replace fixed size takenbuffer with linked list#96
dqii merged 4 commits intolanterndata:@di/linked-list-bufferfrom
ezra-varady:ezra/linked-list-buffer

Conversation

@ezra-varady
Copy link
Copy Markdown
Collaborator

@ezra-varady ezra-varady commented Aug 29, 2023

this PR fixes #52. I wasn't sure what to do with the assert(false) in am_insert when COPY_NODES is true. If it's removed tests pass

@dqii dqii changed the base branch from main to @di/linked-list-buffer September 3, 2023 01:38
@dqii dqii changed the base branch from @di/linked-list-buffer to main September 3, 2023 01:40
@dqii dqii changed the base branch from main to @di/linked-list-buffer September 3, 2023 01:41
@dqii dqii merged commit 70e2ddd into lanterndata:@di/linked-list-buffer Sep 3, 2023
Ngalstyan4 pushed a commit that referenced this pull request Sep 3, 2023
Co-authored-by: Di Qi <di@lantern.dev>
Co-authored-by: Ezra Varady <76978395+ezra-varady@users.noreply.github.com>
@ezra-varady
Copy link
Copy Markdown
Collaborator Author

Thanks for merging! I apologize for submitting and going afk

Ngalstyan4 added a commit that referenced this pull request Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use linked lists in place of a fixed sized array in takenbuffers and copynodes

2 participants