Merged
Conversation
This was
linked to
issues
Aug 25, 2023
Contributor
Author
|
TODO: Redo the out files once bug with REAL[] definition is fixed |
var77
approved these changes
Aug 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 82.65% 83.16% +0.50%
==========================================
Files 11 12 +1
Lines 865 891 +26
Branches 162 175 +13
==========================================
+ Hits 715 741 +26
+ Misses 71 67 -4
- Partials 79 83 +4
|
Contributor
Author
|
I restructured the tests to avoid duplicate tests, and add the vector tests. I also fixed the discussed bug with DatumGetVector so I could get meaningful results in my out files. I also removed some of the "todos" that were already completed, and added a new "todo" (bug with hamming distance). |
Closed
siddharth1729
pushed a commit
to siddharth1729/lanterndb
that referenced
this pull request
Aug 28, 2023
* Add total index size to ldb_get_indexes * Better separate tests into files * Install system dependencies before COPY to improve Docker caching * Fix: Handle datums for real arrays (WIP) * Add tmux to Dockerfile for debugging * Fix: int array handling * Fix: Revert some tests, fix some test bugs * Remove completed todos, add new todo * Add clang-format to dev container, format code * Change float to float4 * Formatting nit * Fix: scan.h forgotten vector call * Add distance function error cases to tests * Add to todo: we expect an error to be thrown when index not created * Restore k iteration tests * Add test cases for distance function dimension errors * Add tests for vector_l2sq_dist * typo * Verify that index is not used without order by * Bug: off instead of false * Remove primary key for tests, test select for 1k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.