Skip to content

Added chnges in readme file#54

Merged
Ngalstyan4 merged 3 commits intolanterndata:main-devfrom
siddharth1729:main
Aug 19, 2023
Merged

Added chnges in readme file#54
Ngalstyan4 merged 3 commits intolanterndata:main-devfrom
siddharth1729:main

Conversation

@siddharth1729
Copy link
Copy Markdown
Contributor

Please review this and provide guidance on any additional steps I should take.

I'm eager to contribute to this project as a backend developer who's deeply interested in databases and low-level technologies. I'm actively learning and find this repository particularly intriguing.

It would be beneficial to have a Discord group where contributors can ask questions, gain a better understanding of the project's concepts, align their efforts with project ideas, and engage in casual conversations.

Looking forward to your insights and suggestions.

https://thelegion.tech is my profilio to know more about me.

Copy link
Copy Markdown
Contributor

@Ngalstyan4 Ngalstyan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expressing interest, @siddharth1729!
We will have a Discord soon. Will e-mail you in the meantime.

README.md Outdated
- `g++` (version >= ?)
- `postgres` (version >= ?)
- `cmake` (version >= ?)
- `make` (version >= ?)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These do not go in the main readme. We will have them in our docs.
However, if you have old versions of each and could help us on which versions LanternDB does not compile, that would be helpful.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohk will remove this for time being

README.md Outdated

#### Installing pgvector

Before proceeding, you need to install [pgvector](https://github.com/pgvector/pgvector), which is a dependency for LanternDB.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will soon be unnecessary. no need to add it to the readme.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do same for this also and make new commit soon

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done pleas have a look @Ngalstyan4

@Ngalstyan4 Ngalstyan4 changed the base branch from main to main-dev August 19, 2023 22:32
@Ngalstyan4
Copy link
Copy Markdown
Contributor

Thanks for your contribution, @siddharth1729!

@Ngalstyan4 Ngalstyan4 merged commit 38a3257 into lanterndata:main-dev Aug 19, 2023
var77 added a commit that referenced this pull request Oct 8, 2024
* Add external index jobs, refactor codes, add cancel handlers for all jobs

* Fix progress tracking for external index

* Added tests for daemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants