Added autogeneration for lanterdb.control file from CMake#53
Merged
Ngalstyan4 merged 5 commits intolanterndata:mainfrom Aug 15, 2023
Merged
Added autogeneration for lanterdb.control file from CMake#53Ngalstyan4 merged 5 commits intolanterndata:mainfrom
Ngalstyan4 merged 5 commits intolanterndata:mainfrom
Conversation
Collaborator
|
Looks good to me! |
Ngalstyan4
reviewed
Aug 14, 2023
Contributor
Ngalstyan4
left a comment
There was a problem hiding this comment.
Thanks for your contribution, Aryan!
Can you move the template file to the cmake directory?
6c451a9 to
bb6058a
Compare
Contributor
Author
|
@Ngalstyan4 updated the implementation |
Ngalstyan4
reviewed
Aug 14, 2023
Contributor
Author
var77
added a commit
that referenced
this pull request
Oct 8, 2024
* Fix column names for index autotune * Try to reduce memory usage on index creation * Drop variables as soon as they are not needed anymore * Drop values outside and remove unnecessary cursor close statement * Change internal schema name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Only thing that changes with every release is the LANTERNDB_VERSION number, which already needs to be set in CMakeLists.txt
Doing so in the lanterndb.control file manually can be eliminated with this autogeneration added in CmakeLists
Testing Notes:
cmake ..from the.\buildfolder. It should generate thelanterndb.controlfile in the base directory.Resolves #30