Skip to content

Fix pgvector package install & introduce ".dockerignore"#39

Closed
charmitro wants to merge 1 commit intolanterndata:mainfrom
charmitro:dockerignore
Closed

Fix pgvector package install & introduce ".dockerignore"#39
charmitro wants to merge 1 commit intolanterndata:mainfrom
charmitro:dockerignore

Conversation

@charmitro
Copy link
Copy Markdown

@charmitro charmitro commented Aug 9, 2023 •
edited
Loading

In this patch:

  1. Install "postgresql-15-pgvector" instead of "postgres-15-pgvector" since it doesn't exist.
  2. Introduced .dockerignore to avoid:
    • build failures due to "build/" being copied to the build stage
    • avoid copying other out-of-date files (*.so etc.)

Solving the following:

2.909 E: Unable to locate package postgres-15-pgvector
------
Dockerfile.dev:6
--------------------
   5 |     # Set Locale
   6 | >>> RUN apt update && apt-mark hold locales && \
   7 | >>> # Install required packages for build
   8 | >>> apt install -y --no-install-recommends build-essential cmake postgresql-server-dev-15 gdb wget postgres-15-pgvector python3-pip sudo && \
   9 | >>>     pip install libtmux --break-system-packages
  10 |
--------------------
ERROR: failed to solve: process "/bin/sh -c apt update && apt-mark hold locales && apt install -y --no-install-recommends build-essential cmake postgresql-server-dev-15 gdb wget postgres-15-pgvector python3-pip sudo &&     pip install libtmux --break-system-packages" did not complete successfully: exit code: 100
17.67 mkdir: cannot create directory ‘build’: File exists
------
Dockerfile:7
--------------------
   5 |     COPY . /tmp/lanterndb
   6 |
   7 | >>> RUN PG_VERSION=$PG_VERSION ./tmp/lanterndb/ci/scripts/build-docker.sh
   8 |
--------------------
ERROR: failed to solve: process "/bin/sh -c PG_VERSION=$PG_VERSION ./tmp/lanterndb/ci/scripts/build-docker.sh" did not complete successfully: exit code: 1

@charmitro
Fix pgvector package install & introduce .dockerignore
e266c30 
In this patch:
  1. Install "postgresql-15-pgvector" instead of "postgres-15-pgvector"
     since it doesn't exist.
  2. Introduced .dockerignore to avoid:
       * build failures due to "build/" being copied to the build stage
       * avoid copying other out-of-date files ("*.so" etc.)

Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net>
@Ngalstyan4
Copy link
Copy Markdown
Contributor

Ngalstyan4 commented Aug 11, 2023

Thanks for your contribution, Charalampos!
I am a little reluctant about adding a .dockerignore file. My understanding is people usually make their Docker images more precise, so the image only copies the necessary files/folders.

Can we do that? COPY only the files and folders that we need in the image in stead of using the COPY . dest wildcard.

var77 added a commit to var77/lantern that referenced this pull request Aug 12, 2023
@var77
Fix header import, fix development dockerfile covers lanterndata#34 l…
8cf19ab 
…anterndata#39
var77 added a commit to var77/lantern that referenced this pull request Aug 16, 2023
@var77
Fix header import, fix development dockerfile covers lanterndata#34 l…
bae4963 
…anterndata#39
Ngalstyan4 pushed a commit that referenced this pull request Aug 18, 2023
@var77 @Ngalstyan4
Fix header import, fix development dockerfile covers #34 #39
76c65b1
@Ngalstyan4
Copy link
Copy Markdown
Contributor

Ngalstyan4 commented Aug 18, 2023

Updated and fixed by #46
Thanks for spotting the issue and for the initial PR!

@Ngalstyan4 Ngalstyan4 closed this Aug 18, 2023
var77 added a commit that referenced this pull request Oct 8, 2024
@var77
Collect update jobs non-blocking (#39)
2e9573c 
* Make row locking non-blocking

* Remove unnecessary deref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@var77 var77

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@charmitro @Ngalstyan4 @var77