create index with dynamically allocated blockmaps#32
Merged
Ngalstyan4 merged 7 commits intomainfrom Aug 9, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 78.45% 80.61% +2.15%
==========================================
Files 10 10
Lines 803 815 +12
Branches 176 169 -7
==========================================
+ Hits 630 657 +27
+ Misses 92 75 -17
- Partials 81 83 +2
|
f12419a to
2898ba3
Compare
build index fixed, retreiver fixed minor fixes another bug found dockerfile update, insert added, test fixed more fixes, still more bugs to go final bugs fixed
2898ba3 to
b8157c5
Compare
Ngalstyan4
commented
Aug 8, 2023
| RUN apt update && apt-mark hold locales && \ | ||
| # Install required packages for build | ||
| apt install -y --no-install-recommends build-essential cmake postgresql-server-dev-15 gdb | ||
| apt install -y --no-install-recommends build-essential cmake postgresql-server-dev-15 gdb wget postgres-15-pgvector python3-pip sudo && \ |
Contributor
Author
Collaborator
There was a problem hiding this comment.
Yes they're necessary for the livedebug script to work in the container.
davkhech
reviewed
Aug 8, 2023
| hdr_page = BufferGetPage(hdr_buf); | ||
| hdr = (HnswIndexHeaderPage *)PageGetContents(hdr_page); | ||
| assert(hdr->magicNumber == LDB_WAL_MAGIC_NUMBER); | ||
| HEADER_FOR_EXTERNAL_RETRIEVER = *hdr; |
Contributor
There was a problem hiding this comment.
no need to add here, as it's assigned later out of if block
Contributor
Author
There was a problem hiding this comment.
needed because ldb_wal_retriever_area_init uses it :)
Contributor
|
LGTM! |
b8157c5 to
5ddfaa5
Compare
var77
added a commit
that referenced
this pull request
Oct 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.